Re^3: Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1


Syntactic Confectionery Delight
	PerlMonks

Re^3: Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1

by swl (Parson)

on Feb 06, 2019 at 23:58 UTC ( [id://1229505]=note: print w/replies, xml )

Need Help??

in reply to Re^2: Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1
in thread Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1

Thanks for checking.

It fails if there were three or more zeroes (the test case provided has two zeroes), and if there are no zeroes.

Adding some extra checks seems to fix the issues, and is still close to try1a for speed given the provided test data (sometimes as fast but usually a few percent slower).

    swl2 => sub {
        my @list = @input;
        use List::MoreUtils 0.428;
        @list = sort {$a<=>$b} @list;
        my $i = List::MoreUtils::bsearchidx {$_ <=> 0} @list;
        if ($i < 0) {  #  no zero
            $i = List::MoreUtils::firstidx {$_ >= 0} @list;
        }
        else {
            $i-- while !$list[$i];
            $i++;
        }
        push @list, splice @list, 0, $i;
        Compare(\@list,\@output) or die "@list" if DO_CHECK;
    },
[download]

It will be slower in cases where there are no zeroes, although List::BinarySearch::binsearch_pos could be used to find an insert point for zero in such cases.

Comment on Re^3: Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1 Download Code

Replies are listed 'Best First'.

Re^4: Fastest way to sort a list of integers into 0,1,2,3,-3,-2,-1
by swl (Parson) on Feb 07, 2019 at 00:53 UTC

Another update to handle lists where all values are >= 0 (as flagged in 1229492). Also using the while loop instead of List::MoreUtils::firstidx based on the benchmarks in that post.

EDIT - added check for upper bound being >=0, borrowing from code in 1229437.

    swl3 => sub {
        my @list = @input;
        use List::MoreUtils 0.428;
        @list = sort {$a<=>$b} @list;
        if ($list[0] < 0 && $list[-1] >= 0) {
            my $i = List::MoreUtils::bsearchidx {$_ <=> 0} @list;
            if ($i < 0) {  #  no zero, find first positive
                $i = 0; $i++ while ($list[$i]<0);
            }
            else {  #  find start of zeroes
                $i-- while !$list[$i];
                $i++;
            }
            push @list, splice @list, 0, $i;
        }
        Compare(\@list,\@output) or die "@list" if DO_CHECK;
    },
[download]

[reply]
[d/l]

In Section Seekers of Perl Wisdom

Domain Nodelet^?

www.com | www.net | www.org

Node Status^?

node history
Node Type: note [id://1229505]
help

Chatterbox^?

How do I use this? • Last hour • Other CB clients

Other Users^?

Others contemplating the Monastery: (3)

As of 2024-04-24 01:27 GMT

Sections^?

Information^?

Find Nodes^?

Leftovers^?

Today I Learned

Voting Booth^?

No recent polls found