in reply to Perl program to search files
Hello harangzsolt33,
One thing I notice is that your sub RSPACE is essentially duplicating part of the functionality already present in Perl’s printf and sprintf builtin functions. In fact, your functions RSPACE and PRINT can be removed altogether, and the two places where PRINT is called can be written as follows:
# (1) in sub SearchFile: PRINT("FOUND: $FULLNAME"); # original printf " %-8dFOUND: %s\n", $TOTAL, $FULLNAME; # replacement # (2) in sub CheckDIR: if ($VERBOSE) { PRINT("SEARCHING: ", FormatPath($PATH)); } + # original printf " %-8dSEARCHING: %s\n", $TOTAL, FormatPath($PATH) if $VERBOSE; + # replacement
Note the use of a statement mofifier in the second case. In general, statement modifiers should be preferred over compound statements whenever a single statement is involved, as this simplifies the code.
Some of your coding conventions could also be improved (IMHO):
- The use of all-uppercase variable names should be reserved for constants.
- Magic numbers (even ASCII values) should be replaced by constants:
use Const::Fast; const my $ASTERISK => 42; const my $DOT => 46; const my $QUESTION => 63; # etc.
- In a script intended to be called directly from the command line, and not used as a module, the distinction between “public” and “private” functions is pointless. (Conversely, if the script is intened to be called as a module, it should begin with an appropriate package declaration.)
I haven’t studied your code in detail. Overall, it looks good: well thought-out and implemented.
Regarding posting:
(1) It would be better to include your code in the question itself (inside <readmore> tags!) than to provide a web address, as the latter is likely to become invalid and so render this thread incomprehensible to future readers.
(2) You say you have tested the program. Adding your test code (again, in <readmore> tags, of course) would aid the monks in evaluating your code.
Hope that helps,
Athanasius <°(((>< contra mundum | Iustus alius egestas vitae, eros Piratica, |
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^2: Perl program to search files
by Tux (Canon) on Dec 28, 2018 at 13:18 UTC | |
by eyepopslikeamosquito (Archbishop) on Dec 28, 2018 at 23:05 UTC |