|Welcome to the Monastery|
Re: Perl program to search filesby Athanasius (Archbishop)
|on Dec 26, 2018 at 04:31 UTC||Need Help??|
One thing I notice is that your sub RSPACE is essentially duplicating part of the functionality already present in Perl’s printf and sprintf builtin functions. In fact, your functions RSPACE and PRINT can be removed altogether, and the two places where PRINT is called can be written as follows:
Note the use of a statement mofifier in the second case. In general, statement modifiers should be preferred over compound statements whenever a single statement is involved, as this simplifies the code.
Some of your coding conventions could also be improved (IMHO):
I haven’t studied your code in detail. Overall, it looks good: well thought-out and implemented.
Hope that helps,