Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

Re: condense conditional

by fullermd (Priest)
on Sep 12, 2018 at 13:14 UTC ( #1222212=note: print w/replies, xml ) Need Help??


in reply to condense conditional

The most direct translation would be to just use a temporary value to store how far down the tree you are. Something like (untested, but perl -c likes it):

if(defined($value)) { chomp($value); my $lval = $devstats->{$nic}; for(my $i = $dirCnt ; $i >= 6 ; $i--) { $lval = $lval->{$data{$i-1}}; } $lval->{$key} = $value; }

Of course, that's a lot of magic numbers, so a better solution is probably to rearrange things to be a little more semantically meaningful. Perhaps in how the filename is assembled, and how you're passing it to readfile(), if that's possible? If not, preprocessing @data a little... it'll be longer, but probably clearer.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1222212]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (3)
As of 2020-10-28 21:00 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    My favourite web site is:












    Results (264 votes). Check out past polls.

    Notices?