Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Re: remove a comma

by golux (Chaplain)
on Jun 21, 2018 at 13:20 UTC ( #1217116=note: print w/replies, xml ) Need Help??


in reply to remove a comma

Hi luupski,

Another way to do this is with the join function, which lets you avoid appending the final comma in the first place.

Read the data from your file, split it on whitespace, join each datum with commas, and surround the entire record with parentheses:

foreach my $line (<$infh>) { if ($line =~ /$re_data/) { # Split on whitespace, surround with parens, join with commas push @data, "(" . join(",", split(/\s+/, $line)) . ")"; } }

and finally, join the records with a comma followed by a newline. The last record won't get a comma (nor newline):

# Simply 'join' all data; last record contains neither comma nor newli +ne. my $data = join(",\n", @data);

Here's an entire working example:

#!/usr/bin/perl use strict; use warnings; use feature qw( say ); use IO::File; ################## ## User-defined ## ################## my $input = 'in.txt'; # Input file my $output = 'out.txt'; # Output file my $re_data = qr/^[0-9]+/; # Detect lines containing records ################## ## Main program ## ################## # Read the input my $infh = IO::File->new($input) or die "Can't read '$input' ($!)"; my @data = ( ); foreach my $line (<$infh>) { if ($line =~ /$re_data/) { # Split on whitespace, surround with parens, join with commas push @data, "(" . join(",", split(/\s+/, $line)) . ")"; } } close($infh); # Simply 'join' all data; last record contains neither comma nor newli +ne. my $data = join(",\n", @data); # Create the output my $text = qq{ SELECT CUSTOMERID, ORDERID, CUSTOMERNAME, CUSTOMERLOCATION FROM DB.CUSTOMER_DATA WHERE (CUSTOMERID, ORDERID, CUSTOMERNAME, CUSTOMERLOCATION) IN ( $data ) }; $text =~ s/\n\s+/\n/g; # Remove indentation (for "looks") # Write the output my $outfh = IO::File->new; open($outfh, '>', $output) or die "Can't write '$output' ($!)"; print $outfh $text; close($outfh); say "Wrote '$output'";

The output for which is:

SELECT CUSTOMERID, ORDERID, CUSTOMERNAME, CUSTOMERLOCATION FROM DB.CUSTOMER_DATA WHERE (CUSTOMERID, ORDERID, CUSTOMERNAME, CUSTOMERLOCATION) IN ( (0001,20000001,john,CA), (0002,30000002,neill,WI), (0003,40000003,joe,GA), (0004,50000004,will,IL), (0005,60000005,mike,IN), (0006,70000006,bill,AK) )
say  substr+lc crypt(qw $i3 SI$),4,5

Replies are listed 'Best First'.
Re^2: remove a comma
by luupski (Initiate) on Jun 21, 2018 at 22:09 UTC

    This works nice

    Had to ditch the +ne from the code and then all worked nicely


    Thanks once more

      Hi luupski,

      I'm not seeing it, but I guess the "+ne" (where "+" is colored red) is a continuation (word wrap) of the comment which ends with:

      # ... last record contains neither comma nor newline.

      You can avoid it by changing increasing the code wrap length in your User Settings or turning off code wrapping.

      Alternatively, you click on any [download] link; these take you to an unadulterated rendering of the text. (This is true for any node containing code samples).

      say  substr+lc crypt(qw $i3 SI$),4,5
Re^2: remove a comma
by luupski (Initiate) on Jun 21, 2018 at 20:06 UTC

    Thank you golux, going to give this a try

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1217116]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others examining the Monastery: (6)
As of 2020-11-27 12:15 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?