Re: regex is not working as I intended

I'm not sure why, but the last alternate ((.*)) seems to win in all cases when the other alternates use a look behind. However, things are much easier to understand if you look around less:

use strict;
use warnings;

my $regex = qr/(' ([^']*) ' | " ([^"]*) " | (.*))/x;

do_test (qq~No quote~); 
do_test (qq~'Single quote'~);
do_test (qq~"Double quote"~);


sub do_test {
   my ($line) = @_;

   print "\n";

   if ($line =~ $regex) {
           print "\$1 is $1.\n" if defined $1;
           print "\$2 is $2.\n" if defined $2;
           print "\$3 is $3.\n" if defined $3;
           print "\$4 is $4.\n" if defined $4;
   } else {
      print "No match.\n";
   }
}
[download]

Prints:


$1 is No quote.
$4 is No quote.

$1 is 'Single quote'.
$2 is Single quote.

$1 is "Double quote".
$3 is Double quote.
[download]

Note too various other tidy ups in the code, especially avoiding calling subs with & (which doesn't do what you think) and excessive use of \.

Premature optimization is the root of all job security

Comment on Re: regex is not working as I intended Select or Download Code

Replies are listed 'Best First'.
Re^2: regex is not working as I intended by ikegami (Patriarch) on Jan 19, 2018 at 05:20 UTC
I'm not sure why, At position 0, `(?<=\')(.?)(?>\')` can't possibly match (there can't be a `'` before the first character), `(?<=\")(.?)(?>\")` can't possibly match (there can't be a `"` before the first character), but `(.*)` always matches. Since it matched at position 0, it doesn't try to match at position 1 (where one of the first two alternates has a chance of matching).	[reply] [d/l] [select]
Re^3: regex is not working as I intended by fireblood (Scribe) on Jan 22, 2018 at 19:11 UTC
I forgot to mention that this regex is used repeatedly on the same string to parse out parameter and value pairs, such as the following: `radius = 3, density = .014, URL = "https://www.geometry.org", max_no_of_attempts = 4` [download] That is why the lookbehind and lookahead assertions are used, even though they cannot possibly match at the beginning or end of the overall parameter string, they can match at intermediate positions as the regex is used to walk over the value of the parameter string parsing out individual parm and value pairs.	[reply] [d/l]
Re^4: regex is not working as I intended by AnomalousMonk (Archbishop) on Jan 23, 2018 at 01:05 UTC
Further to GrandFather's post: Part of the useful enhanced context would be an expected hash structure for each multiple parameter/value pair string (hopefully, more than just one!) that you provide. E.g., for the multi-line string example here, do you expect `%values = ( 'radius' => 3, 'density' => .014, 'URL' => '"https://www.geometry.org"', 'max_no_of_attempts' => 4, );` [download] or do you want something like `%values = ( ..., 'URL' => 'https://www.geometry.org', ..., );` [download] (double-quotes stripped away)? How should wonky quoted strings be handled? By die-ing. By warn-ing and continuing to process? In another way? And yes, I think a module probably already exists to do this sort of thing. Give a man a fish: `<%-{-{-{-<`	[reply] [d/l] [select]
Re^4: regex is not working as I intended by GrandFather (Saint) on Jan 22, 2018 at 22:38 UTC
Maybe you should create a new node with a bit more of the context for this problem. It sounds to me like there could be a call for a bigger hammer than just a single regex. Premature optimization is the root of all job security	[reply]
Re^4: regex is not working as I intended by ikegami (Patriarch) on Jan 22, 2018 at 23:15 UTC
That doesn't change anything. The fixed version provided by Grandfather can be used to in parsing the snippet you provided.	[reply]


Problems? Is your data what you think it is?
	PerlMonks