Re: Combining Files using Hash

pls use,

use strict; use warnings; for better error. $value3 are not initialized. Anyone know how to fix this?

my($key,$value1,$value2,$value3) = $line =~ /(\w+),(\d+.\d+),(.\d+\s+\
+d+.\d+.)/g;
[download]

In regular expression you have only three group and assigning into four variables, so $value3 will be undef.

Update:

Here its the fixed code

use strict;
use warnings;

my %file1Hash;
my $value4;

open my $file1, "<","file1.csv" or die $!;
open my $file2, "<","file2.csv"or die $!;
open my $outfile_1, ">", "combined.rpt.csv" or die $!;

while( my $line = <$file1>){
    chomp $line;
    my($key,$value1) = (split /,/, $line);
    $file1Hash{$key} = $value1;
}

while(my $line1 = <$file2>){

        chomp $line1;
        my($key1) = (split /,/, $line1);

        if (exists $file1Hash{$key1}) {
                print $line1.",".$file1Hash{$key1}."\n";
                    }
        else {
                #  print $line1."\n";
                    }
}

close $file1;
close $file2;
close $outfile_1;

exit 0;
[download]

All is well. I learn by answering your questions...

Comment on Re: Combining Files using Hash Select or Download Code

Replies are listed 'Best First'.
Re^2: Combining Files using Hash by chaney123 (Acolyte) on Sep 05, 2017 at 07:07 UTC
Hi, I tried this and "Use of uninitialized value $key in exists at reformat_rpt.pl" and "Use of uninitialized value $key1 in exists at reformat__rpt.pl" are shown. Why does this happen? Thanks	[reply]
Re^3: Combining Files using Hash by poj (Abbot) on Sep 05, 2017 at 07:42 UTC
Why does this happen? Maybe you have some blank lines at the end of the file. Add a check like this `while (my $line1 = <$file2>){ next unless ($line1 =~ /\S/); # skip empty lines chomp $line1;` [download] poj	[reply] [d/l]


Problems? Is your data what you think it is?
	PerlMonks