Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

Re: compare two files and print the differences of file 2 in a third file

by robby_dobby (Hermit)
on Jun 14, 2017 at 05:17 UTC ( #1192753=note: print w/replies, xml ) Need Help??


in reply to compare two files and print the differences of file 2 in a third file

Hello Lonnie,

Welcome to the monastery! You're doing a few things that are just considered bad convention:

  • Don't use bare word file handles. Prefer lexical file handles instead. open(my $fh, "<", "/path/here/") or die "Can't open foo: ", $!;
  • Use 3-arg open. Please take a look at perlopentut and the example I quoted above. Using 2-arg open, leaves you vulnerable to security issues.
  • This is a minor issue - have you considered passing in arguments to your subroutine, instead of reading them from STDIN? Passing to subroutine makes it clear what it's doing, besides keeping the whole logic self-contained.

Good on you for posting the code and I can see that you're doing a lot of work, which would just as easily achieved by using an available module such as File::Compare. File::Compare is bundled with standard perl distributions and should be available with your local installation. Sure, it doesn't print the exact differences which is what you wanted to do, but you can copy steal ideas from it, surely? (For example, instead of reading line by line, you can directly read into a buffer on some configurable buffer size using read or sysread functions?)

As always, have fun! :-)

  • Comment on Re: compare two files and print the differences of file 2 in a third file
  • Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1192753]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (4)
As of 2023-02-08 23:23 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I prefer not to run the latest version of Perl because:







    Results (44 votes). Check out past polls.

    Notices?