http://qs321.pair.com?node_id=1165235


in reply to Re: Odd number of elements in anonymous hash
in thread Odd number of elements in anonymous hash

but when $code is true, $attached is a STRING in the OP code. And I couldn't get test code to dereference the string version to include in the new hashref.

Here's some example code which tries and dumps both code=0 and 1:

#!perl
use strict;
use warnings;
use Data::Dumper;

for my $code (0 .. 1) {
    my $attached = $code ? { attach_path => 'etc' } : {};
    my $args = {
        to => 'to email',
        from => 'from email',
        %$attached
    };
    print Dumper($args);
}

[download]

Replies are listed 'Best First'.
Re^3: Odd number of elements in anonymous hash
by Athanasius (Archbishop) on Jun 09, 2016 at 16:23 UTC

    Yes, actually $attached is a single string whether $code is true or false: in the latter case, it’s the empty string. And that means you get a key/value pair in which the string $attached is the key, and the value is undef — which gives the “Odd number of elements” warning.

    The solution is to eval the string:

    #! perl
use strict;
use warnings;
use Data::Dump;

my $body      = 'Hello!';
my $code      =  1;
my $email     = 'addressee';
my $file_name = 'unknown';
my $from      = 'sender';
my $name      = 'A Nonny Mouse';
my $subject   = 'Greeting';
my $attached  =  $code ? "attach_path     => '$file_name', " .
                         "attach_filename => '$file_name', " .
                         "attach_type     => 'application/txt'," : '';

my $success =
   {
       to        => $email,
       from      => $from,
       from_name => $name,
       subject   => $subject,
       body      => $body,
       eval $attached,
   };

dd $success;

    [download]

    Output:

     2:21 >perl 1655_SoPW.pl
{
  attach_filename => "unknown",
  attach_path => "unknown",
  attach_type => "application/txt",
  body => "Hello!",
  from => "sender",
  from_name => "A Nonny Mouse",
  subject => "Greeting",
  to => "addressee",
}

 2:21 >

    [download]

    Hope that helps,

    Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

[reply]
[d/l]
[select]
Re^3: Odd number of elements in anonymous hash
by tangent (Parson) on Jun 09, 2016 at 16:24 UTC
    I didn't notice it was a string, thanks. So it could be done like this, though toolic's answer is cleaner. 
    my $attached = $code ? { attach_path => $file_name, attach_filename =>
+ $file_name, attach_type => 'application/txt' } : {};

    [download]
[reply]
[d/l]
      Thanks for all the help, I like tangent's answer!
[reply]

In Section Seekers of Perl Wisdom