Keep It Simple, Stupid | |
PerlMonks |
Re^13: Question about the most efficient way to read Apache log files without All-In-One Modules from CPAN (personal learning exercise)by BrowserUk (Patriarch) |
on Jun 18, 2015 at 23:33 UTC ( [id://1131088]=note: print w/replies, xml ) | Need Help?? |
quick glance of the source You didnt look close enough. This regex:
Won't match "-", because it expects and requires at least two space delimited fields within the quotes; and allows for a third. Note also that both ID fields are expected to match [^\s]* (I guess he's not aware of \S; and it should at least be + not *; which could be an indication of his perl experience.). So, a "proper parser" would break. Maybe it has a back-up plan for if the regex fails; but equally, it's simple to code a back up plan for the white space split also. So let's review:
So, here we are 13 levels deep; and you've become boring. No attempt to help the OP; just banging on about stuff it seems you barely understand. So, I'm bored and done. T'was fun. Update: I forgot this little gem. You offered this wishy-washy suggestion "or using Text::CSV or somesuch"; but then later suggest that split will break because "which says nothing about logname and user,"; completely oblivious to the fact that if either ID contained spaces; it would break that module also! With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
I'm with torvalds on this Agile (and TDD) debunked I told'em LLVM was the way to go. But did they listen!
In Section
Seekers of Perl Wisdom
|
|