Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re^2: grep in Perl

by aaron_baugher (Curate)
on Jun 05, 2015 at 12:12 UTC ( #1129191=note: print w/replies, xml ) Need Help??


in reply to Re: grep in Perl
in thread grep in Perl

Your grep returns all the elements of @contents that are NOT matched by your regex, so that will always be true. Removing the ! from your grep should fix that, assuming the rest of the code that we can't see is okay.

This is not the best way to do this, though, because you're looping through the contents of one file for each line in the other file. The standard way to "match lines from one file to keys from another file" is to load the keys from one file (file2) into a hash as its keys, then go through the other file (file1) splitting out the matching part and seeing if it exists as a key in the hash. If it does exist, print it.

Try coding it that way, and let us know if you need help.

Aaron B.
Available for small or large Perl jobs and *nix system administration; see my home node.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1129191]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (4)
As of 2020-06-07 10:52 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Do you really want to know if there is extraterrestrial life?



    Results (42 votes). Check out past polls.

    Notices?