Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re: Advice on best practices

by stonecolddevin (Parson)
on Mar 06, 2015 at 17:34 UTC ( #1119073=note: print w/replies, xml ) Need Help??


in reply to Advice on best practices

I think you have some valid concerns, especially if this is code you're working in tandem with.

I think you need to take the human approach here and just ask the person that wrote it or is maintaining it.

"Hey $author, I was taking a look at this code you wrote and I was curious why you did $thing this way?"

This way, it's not confrontational, and they don't really have an excuse to get defensive. You're there purely for educational purposes. I've found a lot of times people get kind of a sheepish look and go "yeaaaa it's really bad code, sorry, I was in an enormous rush etc." If they try to justify it with something stupid, well, you have your answer then.

Three thousand years of beautiful tradition, from Moses to Sandy Koufax, you're god damn right I'm living in the fucking past

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1119073]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (6)
As of 2020-06-04 18:51 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Do you really want to know if there is extraterrestrial life?



    Results (35 votes). Check out past polls.

    Notices?