You need to fix your bugs before declaring that someone's solution for a small question is invalid.

Thi spoiler contains an SSCCE that fixes (some) of your mistakes, with comments. But in brief, you didn't use strict and warnings, so you missed some of the problems; you initialized the wrong variable outside of your loop (which would have been caught by strict/warnings); and your vertical bar split had too many vertical bars, so it never split your loop variable into three variables (instead, putting the whole string in the $favtitle and leaving $favlink and $favnum as undef).

The code below shows the same loop working for both 5 favorites in the string (showing all) and for 30 favorites in the string (showing 25 of them).

edit: struck about the vertical bar; the eventual follow-on data shows that there really are 3 bars between fields. Sorry.

Before the loop remove the excess elements

            splice @favs, 25;
            foreach (@favs){
[download]

splice @favs, 25;
[download]

Note that splice-ing past the end of the array results in a warning in earlier Perl versions:

Win8 Strawberry 5.8.9.5 (32)  Wed 08/31/2022 15:05:47
C:\@Work\Perl\monks
>perl -wMstrict -MData::Dump=dd -le "my @ra = ('a' .. 'd');  splice @r
+a, 10;  dd \@ra"
splice() offset past end of array at -e line 1.
["a" .. "d"]
[download]

(I don't know with what version this warning was suppressed.)

---

Give a man a fish:  <%-{-{-{-<