Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

Re^2: Should I use v5.10 because of named groups?

by hrcerq (Scribe)
on Apr 14, 2021 at 16:16 UTC ( [id://11131280]=note: print w/replies, xml ) Need Help??


in reply to Re: Should I use v5.10 because of named groups?
in thread Should I use v5.10 because of named groups?

I guess you're right, that regex isn't any more readable than the alternatives you propose. In fact, I've rewritten it to:

if (/^([01]):([01]):([^:]+):([^:]+)$/) {
    my ($type, $valid, $name, $coment) = ($1, $2, $3, $4);
    
    ...

[download]
I maintained the regex as I'm fairly sure I'll need to improve it later for more checks on the input.

Replies are listed 'Best First'.
Re^3: Should I use v5.10 because of named groups?
by Marshall (Canon) on Apr 14, 2021 at 22:44 UTC
    Just a nit, in case you didn't know, but you can do the $1,$2,$3,$4 assignment in the if statement:
    if ( my ($type, $valid, $name, $coment) = 
     $_ =~ m/^([01]):([01]):([^:]+):([^:]+)$/ ){}

    [download]
    I don't think this makes much difference. I just have a coding preference to avoid $1, etc.
    I made 2 source lines because of code line length limits here. In actual code, I'd probably just have one line.
[reply]
[d/l]

In Section Seekers of Perl Wisdom

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?

www.com | www.net | www.org
Node Status?
node history
Node Type: note [id://11131280]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? • Last hour • Other CB clients
Other Users?
Others surveying the Monastery: (1)
As of 2024-04-25 19:43 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found