Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re: Critique requested for module code - QuickMemo+ reader

by 1nickt (Canon)
on Jan 24, 2021 at 18:00 UTC ( [id://11127381]=note: print w/replies, xml ) Need Help??


in reply to Critique requested for module code - QuickMemo+ reader

Hi,

Quick observation: I don't think I would return a reference to a string from extract_json_from_lqm -- it complicates the flow down the chain (having to dereference a ref to a scalar). Just return and pass around the string.

Hope this helps!


The way forward always starts with a minimal test.

Replies are listed 'Best First'.
Re^2: Critique requested for module code - QuickMemo+ reader
by Lotus1 (Vicar) on Jan 24, 2021 at 18:31 UTC

    Thanks this helps. I will get rid of the ref for the string. My original module had a function to convert memos to Simplenote format but I decided to simplify down to the bare bones for my first attempt.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://11127381]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others taking refuge in the Monastery: (3)
As of 2024-04-19 22:26 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found