Re^3: What's the right way to write a method which returns one line at a time from a file?


Come for the quick hacks, stay for the epiphanies.
	PerlMonks

Re^3: What's the right way to write a method which returns one line at a time from a file?

by AnomalousMonk (Archbishop)

on Nov 22, 2020 at 07:08 UTC ( [id://11124006]=note: print w/replies, xml )

Need Help??

in reply to Re^2: What's the right way to write a method which returns one line at a time from a file?
in thread What's the right way to write a method which returns one line at a time from a file?

if ( my $line = readline( $self->{file_handle} ) ) { return $line; } else { return; }
[download]

I appreciate old-school, but I think the quoted code will fail to return the last line of a file if it is '0' with no terminating newline. I haven't tested it, but wouldn't

if (defined(my $line = readline( $self->{file_handle} ))) {
    return $line;
} else {
    return;
}
[download]

or even just
return readline($self->{file_handle});
(readline returns undef at eof) be better?

Give a man a fish: <%-{-{-{-<

Comment on Re^3: What's the right way to write a method which returns one line at a time from a file? Select or Download Code

Replies are listed 'Best First'.
Re^4: What's the right way to write a method which returns one line at a time from a file? by Cody Fendant (Hermit) on Nov 28, 2020 at 03:16 UTC
Thanks for your contribution, sorry for the late response. In my case I happen to know that will never happen but perfectly valid point. My code is working but I will improve it with your suggestion.	[reply]

In Section Seekers of Perl Wisdom

Domain Nodelet^?

www.com | www.net | www.org

Node Status^?

node history
Node Type: note [id://11124006]
help

Chatterbox^?

How do I use this? • Last hour • Other CB clients

Other Users^?

Others about the Monastery: (5)

As of 2024-04-24 10:09 GMT

Sections^?

Information^?

Find Nodes^?

Leftovers^?

Today I Learned

Voting Booth^?

No recent polls found