Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

Re: sed/awk/grep to Perl

by BillKSmith (Prior)
on Nov 09, 2020 at 19:18 UTC ( #11123534=note: print w/replies, xml ) Need Help??


in reply to sed/awk/grep to Perl

You seem to be getting a divided opinion. Let me suggest a middle ground. Do not make the suggested changes until you must change the script for any other reason. Then yes, make all the improvements. The benefit of merely changing to pure perl, although real, is probably not worth the effort of validating the new version. If you wait until requirements change, you will already need the validation.
Bill

Replies are listed 'Best First'.
Re^2: sed/awk/grep to Perl
by haukex (Bishop) on Nov 09, 2020 at 20:11 UTC
    You seem to be getting a divided opinion. Let me suggest a middle ground. Do not make the suggested changes until you must change the script for any other reason. Then yes, make all the improvements. The benefit of merely changing to pure perl, although real, is probably not worth the effort of validating the new version. If you wait until requirements change, you will already need the validation.

    I'm not really sure that's a middle ground, rather it seems to be quite similar to choroba's point. I think the "real answer" is: it depends. Since aartist hasn't shown any real-world examples, we don't know if the code in the backticks is innocuous, or whether it depends on a specific shell (brittle) or puts user input into backticks - a major potential security issue. If I were to receive, for example, some legacy C code and I discovered a buffer overflow, I'd want to fix it sooner rather than later, but of course it could be that there are other mitigating factors, like being able to assume the input this program receives is sanitized. In other words, it should be decided on a case-by-case basis what the priority to change the code should be. As a general response, like in my post, I erred on the side of caution, because in my experience backticks without variables interpolated into them are rare.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://11123534]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (6)
As of 2021-04-12 18:52 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?