Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

Re^4: Perl::Critic says don't modify $_ in list functions and other things

by hippo (Chancellor)
on Jul 10, 2020 at 08:22 UTC ( #11119127=note: print w/replies, xml ) Need Help??


in reply to Re^3: Perl::Critic says don't modify $_ in list functions and other things
in thread Perl::Critic says don't modify $_ in list functions and other things

Are the numerical parts of $raw_value positive integers? If so, it's going to be simpler and (I suspect) more efficient to use capture groups and do the maths by hand. eg:

#!/usr/bin/env perl use strict; use warnings; my $raw_value = shift @ARGV; my ($total_value, $base_value, $amount); my $assets = {}; my $lookup_asset = 'foo'; if ($raw_value && $raw_value =~ /(\d+)\*(\d+)/) { $total_value = $1 * $2; # performs multiplication ($amount, $base_value) = ($1, $2); } elsif ($raw_value && $raw_value =~ /(\d+)\/(\d+)/) { $base_value = $1 / $2; # performs division ($total_value, $amount) = ($1, $2); } else { $amount = $raw_value; $base_value = $assets->{$lookup_asset} ? $assets->{$lookup_asset} +: 0; $total_value = $amount * $base_value; } print "Amount: $amount\nBase: $base_value\nTotal: $total_value\nRaw: $ +raw_value\n";

At least, that's how I would go about it.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://11119127]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (8)
As of 2021-01-17 23:11 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Notices?