Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

Re^2: NEW [doc://perldoc#deeplink] works now with all perldocs ( pragmas/modules vs functions conflicts )

by LanX (Cardinal)
on Feb 18, 2020 at 01:22 UTC ( #11113083=note: print w/replies, xml ) Need Help??


in reply to Re: NEW [doc://perldoc#deeplink] works now with all perldocs
in thread NEW [doc://perldoc#deeplink] works now with all perldocs

I've submitted a new patch which should hopefully allow these alternative notations to work properly (after approval)

  • core module:
    [doc://B::Deparse] --> B::Deparse
  • core module.pm: (same)
    [doc://B::Deparse.pm] --> B::Deparse.pm
  • core module deeplink
    [doc://B::Deparse#Synopsis] --> Synopsis

... and for completenes

  • perlvar:
    [doc://$_] --> $_

Cheers Rolf
(addicted to the Perl Programming Language :)
Wikisyntax for the Monastery

updates
  • expanded and commented tests
  • #IMPLEMENTATION-DETAILS was case sensitive
  • added perlvar
  • Comment on Re^2: NEW [doc://perldoc#deeplink] works now with all perldocs ( pragmas/modules vs functions conflicts )
  • Select or Download Code

Replies are listed 'Best First'.
Re^3: NEW [doc://perldoc#deeplink] works now with all perldocs
by kcott (Bishop) on Feb 18, 2020 at 03:48 UTC

    G'day Rolf,

    I don't know if you've made several typos or if there's a problem with your patch. Obviously, as you're awaiting approval for the patch, I can't test it.

    You posted four links; these three are invalid:

    http://perldoc.perl.org/open.pm.html http://perldoc.perl.org/open.pm.html#Implementation-Details http://perldoc.perl.org/B/Deparse.pm.html

    In each case, if you remove the '.pm' part, they will be valid.

    I think it would also be a good test to show the open function ([doc://open]) resolving to https://perldoc.perl.org/functions/open.html and the open pragma ([doc://open.pm]) resolving to https://perldoc.perl.org/open.html.

    Update (additional information): More for completeness than anything else, I'll just add the http: is converted to https: by perldoc.perl.org regardless of whether the link is valid or not.

    — Ken

        Fair enough. Thanks for the clarification.

        By the way, I think this is a very good idea: both you and anonymonk got a ++ from me.

        Update: Changed "you got a ++" to "both you and anonymonk got a ++".

        — Ken

Re^3: NEW [doc://perldoc#deeplink] works now with all perldocs
by jdporter (Canon) on Feb 18, 2020 at 16:05 UTC

    [doc://open.pm#Implementation-Details] --> Implementation Details
    FAILs... because apparently anchor names are case sensitive, and the anchor names in use (mostly?) on perldoc.perl.org are AlL-cApS. Try:

    [doc://open.pm#IMPLEMENTATION-DETAILS] --> Implementation Details

    Should we convert the user-supplied anchor name to uppercase for this purpose? I tend to think so... but only if we believe that that will work 99.9% of the time for perldoc.perl.org.

    I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.
      > FAILs... because apparently anchor names are case sensitive,

      Race commenting, I ran and expanded the tests as soon as I saw your approval :)

      > Should we convert the user-supplied anchor name to uppercase for this purpose?

      No, I don't think so, we can't keep up to date with changes in perldoc.perl.org.

      The author of the post should care.

      Cheers Rolf
      (addicted to the Perl Programming Language :)
      Wikisyntax for the Monastery

Re^3: NEW [doc://perldoc#deeplink] works now with all perldocs
by erzuuli (Friar) on Feb 18, 2020 at 16:08 UTC
    I've submitted a new patch...

    Applied.

        Would you mind writing the Tidings entry? I'll do it if you'd really rather not.

        Thank you, sir!

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://11113083]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (5)
As of 2020-08-06 06:46 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Which rocket would you take to Mars?










    Results (38 votes). Check out past polls.

    Notices?