|
Re: SQL query using elements from array
by kennethk (Abbot) on Oct 03, 2014 at 19:39 UTC
|
Rather than interpolating values directly into your SQL, you should probably get into the habit of using placeholders. In addition to improving security, it handles escaping for you. It also lets you only prepare your statement once, and use it multiple times. By moving that and your connect statement outside the loop, you'll likely find my rewrite runs substantially faster.
#!/usr/bin/perl
use DBI;
use strict;
my @date1 = ('2013-08-01 00:00:00.000','2013-08-02 00:00:00.000');
my @date2 = ('2013-08-02 00:00:00.000','2013-08-03 00:00:00.000');
my $dbh = DBI-> connect('dbi:ODBC:DSN=TEST-DB1;UID=SA;PWD=pass') or di
+e "CONNECT ERROR! :: $DBI::err $DBI::errstr $DBI::state $!\n"
my $sql2 = <<EOSQL;
SELECT Login_ID, AuditChrt_TimeStamp, Patient_ID
FROM TopsData.dbo.AUDT_AuditChrt
WHERE master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) >= ?
AND master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) <= ?
EOSQL
my $sth = $dbh->prepare($sql2);
foreach my $i (0 .. @date1 - 1) {
$sth->execute($date1[$i], $date2[$i]);
my @row;
while (@row = $sth->fetchrow_array) { # retrieve one row at a tim
+e
print join(", ", @row), "\n";
}
}
END {
$dbh->disconnect if $dbh;
}
Other changes I made:
I used a heredoc (Quote and Quote like Operators in perlop) to separate the SQL from the Perl code; IMHO, it makes things more legible
I swapped to a foreach loop, since that structure is less bug prone than C-style loops -- fewer moving parts.
I moved the disconnect to an END block (with conditional) so that no matter how your code exits, you won't get that pesky Issuing rollback warning.
Update: Corrected copy&paste bug, as per McA's comment below. I concur that an AoA is a better data structure here, but wanted to not get too far too fast...
#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.
| [reply]
[d/l]
[select] |
|
|
my @date1 = ('2013-08-01 00:00:00.000','2013-08-02 00:00:00.000');
I would go one step further for clarification of the intention of the code. Why not doing the following to emphasis on the fact that the author wants to interate over several time intervals:
my @intervals = (
['2013-08-01 00:00:00.000', '2013-08-02 00:00:00.000'],
['2013-08-02 00:00:00.000', '2013-08-03 00:00:00.000'],
);
...
foreach my $interval (@intervals) {
$sth->execute(@$interval);
...
}
And as soon as you look at the intervals and at the SQL statement you see that AllPaoTeam made a litte mistake concerning interval boundaries IMHO. Make one end of the interval inclusive the other end exclusive:
WHERE master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) >= ?
AND master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) < ?
otherwise you would count entries on 2013-08-02 00:00:00.000 twice (except for being intended).
Regards
McA | [reply]
[d/l]
[select] |
|
|
True, I did make that error, nice catch! Thanks to everyone with help me with this, Kudos to all!!
| [reply] |
Re: SQL query using elements from array
by mr_mischief (Monsignor) on Oct 03, 2014 at 19:46 UTC
|
Read this, then look at your code.
push @date1, "'; drop table TopsData.dbo.AUDT_AuditChrt; --"
Now, take placeholders seriously.
| [reply]
[d/l] |
Re: SQL query using elements from array
by toolic (Bishop) on Oct 03, 2014 at 17:35 UTC
|
Single quotes (q) prevent variable interpolation. $sql2 contains the literal string $date1[$i], not its value ('2013-08-01 00:00:00.000').
Tip #2 from the Basic debugging checklist (print). Try qq
my $sql2 = qq/SELECT Login_ID, AuditChrt_TimeStamp, Patient_ID
FROM TopsData.dbo.AUDT_AuditChrt
WHERE master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) >= $d
+ate1[$i]
AND master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) <=
+$date2[$i]/;
| [reply]
[d/l]
[select] |
Re: SQL query using elements from array
by vinoth.ree (Monsignor) on Oct 03, 2014 at 17:22 UTC
|
| [reply] |
Re: SQL query using elements from array
by mje (Curate) on Oct 06, 2014 at 13:55 UTC
|
As an aside to the problem you are posting about (which is answered) why are you converting (with fn_sqlvarbasetostr) what looks like a timestamp to a string to compare with a string timestamp? Why not forget fn_sqlvarbasetostr and simply make your timestamps like "{ts '1998-05-02 01:23:56.123'}". You can omit the milliseconds.
| [reply] |
|
|
How would I incorporate into the Perl code? Using code from McA, it tried the code below, but errors. I also tried using double quotes around it between the brackets. Below is the code and the error:
my @intervals = ([{ts'2012-07-01 00:00:00.000'},{ts'2012-07-02 00:00:0
+0.000'}],
[{ts'2012-07-02 00:00:00.000'},{ts'2012-07-03 00:0
+0:00.000'}]);
Error:"Bad Name after ts' at line 17" which is the line above.
| [reply]
[d/l] |
|
|
my @intervals = (
["{ts'2012-07-01 00:00:00.000'}",
"{ts'2012-07-02 00:00:00.000'}"],
["{ts'2012-07-02 00:00:00.000'}",
"{ts'2012-07-03 00:00:00.000'}"]);
poj | [reply]
[d/l] |
|
|
| [reply] |
|
|
|
|
|
|
|
I am assuming this is in perl and not using the function within SQL Server? I can try it and see if it works.
Thanks for the suggestion!
| [reply] |
