Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Re^3: Regex shows only last match multiple times?

by Athanasius (Archbishop)
on Aug 08, 2014 at 15:51 UTC ( #1096777=note: print w/replies, xml ) Need Help??

in reply to Re^2: Regex shows only last match multiple times?
in thread Regex shows only last match multiple times?

If you add use warnings; to the head of your script, Perl will tell you that the opening of the while loop:

while ($i = 1) {

contains a logic error: it re-initialises the variable to 1 on each loop iteration. In fact, this loop would benefit from a complete re-write:

use strict; use warnings; my $c; for (my ($valid, $try) = (0, 1); !$valid; ++$try) { print "Enter the range of the array (try $try):\n"; chomp($c = <STDIN>); if ($c =~ /^\d+$/) { print "You have entered a valid range: $c\n"; $valid = 1; } elsif ($try < 3) { print "The input is invalid, please enter digits only\n"; } else { print "No valid array range entered, exiting\n"; exit; } } print "Continuing...\n";

This is one of the unusual cases in which a C-style for loop is useful in Perl. Please note:

  • I have also added use strict; and declared all variables as lexicals with my. The amount of time this will save you down the track far outweighs the (very small) extra effort required.
  • In future, please put <code> ... </code> tags around your code, to make it readable.
  • When asking a question (as opposed to commenting on someone else’s answer), it’s usually better to open a new thread.

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1096777]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (4)
As of 2022-01-22 06:01 GMT
Find Nodes?
    Voting Booth?
    In 2022, my preferred method to securely store passwords is:

    Results (61 votes). Check out past polls.