You return \%no_access_brks but that does not appear anywhere in the sub, did you intend to return \%no_name_found?

It is not really clear what you are trying to achieve here. Your variable naming convention really does not make it clear what the desired output is.
You do some undefined check on $user_name and put the results in $no_name which you do not use. You push the city value into an array but try to print as a scalar, perhaps a hash of arrays is not the appropriate data structure to use.

Here is a slightly modified version of your code that uses a check_name sub and correctly displays the array contents. Hopefully this gives you a clue as to how to modify your code to achieve your goal.

use strict;
use warnings;

my $result = data();

foreach my $key ( keys %$result ) {
        my $value = join(',', @{$result->{$key}});
        print "User Name = $key - City: $value\n";
}


sub data {

    #db code stuff
    my $sql = [
                { username => 'abc', city=> 'foo' },
                { username => 'def', city=> 'bar' },
                { username => 'ghi', city=> 'goo' },
                { username => 'jkl', city=> 'car' },
                { username => 'm-n-o', city=> 'car' },
                ];
    #...
    my %no_name_found;
    if ( @$sql ) {

        for ( @$sql ) {
            my $user_name = $_->{'username'};
            my $city = $_->{'city'}  || '';

            if ( check_name( $user_name ) ) {
                push @{ $no_name_found{ $user_name } }, $city;
            }
        }

    }
    return \%no_name_found;
}

sub check_name {
    my $name = shift;
    if ( $name =~ /^\w+$/ ) {
        return $name;
    }
}

Output
User Name = def - City: bar,bas
User Name = abc - City: foo
User Name = jkl - City: car
User Name = ghi - City: goo
[download]

If you still are having problems please provide a more detailed description of what you are trying to achieve, include all relevant subs and a sample of input data and how you want it to display on output.

Yes, I'm sorry!

Problems like this can be avoided with the strict pragma. See Use strict warnings and diagnostics or die for a more thorough discussion.

---

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

OK, this I found to be the better way of doing it:



my $result = data();

foreach my $res (@$result) {

        my $name = $res->{'username'};
        my $city = $res->{'city'};
        print "User Name = $name - City: $city\n";
    }

my @all_data = ();
sub data {
...
db code stuff
...
 my %no_name_found;
 if(@$sql) {
     
   for(my $i = 0; $i < @$sql; $i++) {


     my $user_name   = $sql->[$i]{'username'}  || '';
     my $city      = $sql->[$i]{'city'}  || '';

     # verify user name, this name will come back from this sub check_
+name
     my $no_name = check_name (
                               user => $user_name,
                               );
     
    #Get a new hash for the data
    my %data;
    $data{username} = $user_name;
    $data{city}      = $city;
    push @all_data, \%data;
   

   }
  
  
 }
 
 return \@all_data;

}
[download]

    push @{ $no_name_found { $user_name } }, $city;
[download]

        my $value = $result->{$key};
        print "User Name = $key - City: $value\n";
[download]

User Name = User - City: ARRAY(0x3eafa1c)
[download]

        my $value = $result->{$key};
        local $" = ', ';
        print "User Name = $key - City: @$value\n";
[download]

        my $value = $result->{$key};
        print "User Name = $key - City: ", join(', ', @$value), "\n";
[download]