Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re^2: Printing line before matching expression

by hdb (Monsignor)
on Sep 11, 2013 at 06:43 UTC ( #1053417=note: print w/replies, xml ) Need Help??


in reply to Re: Printing line before matching expression
in thread Printing line before matching expression

It seems a bit of overhead to me if you use an array of the required buffer size to store the linked list and the data. What you save compared to other proposals is the pushing and shifting which involves a lot of copying data around. This can be done more easily by cycling through the buffer using the modulo operator on the line number of the data.

use strict; use warnings; my $lookback = 3; my $match = qr/\wiz/; my @lbuff; while (<DATA>) { /$match/ and defined $lbuff[ $. % $lookback ] and print "$lbuff[ $ +. % $lookback ]"; $lbuff[ $. % $lookback ] = $_; } __DATA__ foo bar baz biz buz goo car caz ciz cuz

Replies are listed 'Best First'.
Re^3: Printing line before matching expression
by Anonymous Monk on Sep 11, 2013 at 07:54 UTC

    compared to other proposals is the pushing and shifting which involves a lot of copying data around.

    Sure it doesn't :)

    This can be done more easily by cycling through the buffer using the modulo operator on the line number of the data.

    If all the data you want is at the end

    my @data = ( undef, undef, qw/ bingo nameo / ); print @data[ -1,-2,-3 ]; __END__ nameobingo
Re^3: Printing line before matching expression
by jaredor (Priest) on Sep 11, 2013 at 18:56 UTC

    A small suggestion would be adding one more slot to the buffer and using some perl idiomcyncracies (sic) to reduce the need to manipulate the buffer in the inner loop:

    #!/usr/bin/env perl use Modern::Perl; my $lb = 3; # lookback my $match = qr/\wiz/; my @buff; while ($buff[$.%($lb+1)] = ($_ = <DATA>)) { my $lbi = ($.+1)%($lb+1); # lookback index print $buff[$lbi] if defined $buff[$lbi] and /$match/; } __DATA__ foo bar baz biz buz goo car caz ciz cuz

    P.S. Thanks for optimizing my two line circular linked list declaration to zero lines! ;-)

    P.P.S. Too bad: Yours is, IMHO, the best answer to the OP, but is buried in this subthread.

    EDIT Just reviewed this code and saw that I forgot defined! This opens the door for error if the lookback line is empty or a zero. While I was at it, I changed the emphasis from the lookback line itself to the index that finds it; plus, no more relying on side effects in the conditional.

    For the three of y'all who upvoted the earlier incarnation, the original code is below. One line was deleted, one line added, one line changed.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1053417]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (6)
As of 2021-03-05 14:39 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    My favorite kind of desktop background is:











    Results (112 votes). Check out past polls.

    Notices?