Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: Review of my script

by TomDLux (Vicar)
on May 15, 2013 at 20:10 UTC ( [id://1033735] : note . print w/replies, xml ) Need Help??

in reply to Review of my script

There are a number of details I would nit-pick about, but, after all, you're applying to be an intern, not the company guru. It looks mostly correct, I'll assume you've verified it works, and does what it's supposed to.

Two things I would suggest, however.

  • use autodie ':all'; then you don't need to check open(), close(), system calls for success or failure. The call will die automatically, with appropriate error message, if anything goes wrong. And if you DO want to trap errors, use autodie, and then use Try::Tiny to implement a try{}catch{} block.
  • I was gonna suggest something about DBI, but it looks like only one actually query is used.

As Occam said: Entia non sunt multiplicanda praeter necessitatem.