note
ysth
This is definitely the place to ask (though the chatterbox is an alternative). I think this was broken quite recently, with this innocuous looking change to scratchpad_link:
<code>
- my $user = getNodeById($user_id);
+ my $user = $user_id=~/\D/ ? getNode($user_id, 'user') : getNodeById($user_id);
</code>
where in one particular case, the passed-in user_id was actually a user node object instead (which getNodeById blithely allows). I find this kind of amusing, that an attempt to make
one piece of code more generous in what kinds of input it takes was foiled by another piece of code with a similar generousity :)
<p>
I'd rather see routines expect the kind of data they really want, and rely on the caller to do any transformation needed (in the case of the change above, handlelinks_settings).
<p>
Update: the problem is fixed (or at least worked-around) now.
370215
370215