http://qs321.pair.com?node_id=736160


in reply to Win32::OLE & Excel help

Hi imrags,

I have not benchmarked, but by adding next we can avoid some extra executions. It is not going to boost more performance, but slight improvement will be there.

use strict;
use warnings;

for my $i (1 .. $LastRow)
{    
    if ($Sheet->Range("E$i")->{Value} =~ /MSD/){
                
        next;
        
    }
    else{

            $CB_COUNT++;
        
            if ( $Sheet->Range("J$i")->{Value} !~ /No_/i){
                             
                    $NM_COUNT++;
                        
            }                    
                            
    }

[download]

OP has updated the code. Posted solution for the previous one.
update: Removed extra 'if' statement in 'else' part.

Prasad

Replies are listed 'Best First'.
Re^2: Win32::OLE & Excel help
by gone2015 (Deacon) on Jan 14, 2009 at 11:20 UTC

    You'll get a little extra benefit if you avoid entering a BLOCK, so:

      for my $i (1 .. $LastRow) {
    next if ($Sheet->Range("E$i")->{Value} =~ /MSD/) ;
    $CB_COUNT++;

    next if ($Sheet->Range("J$i")->{Value} =~ /No_/i) ;
    $NM_COUNT++;
  }

    [download]
    but as noted elsewhere, the major time cost is probably in the OLE calls.

    Is it possible to pull a range into an array ? I'm thinking: @stuff = $Sheet->Range("J1:J$lastrow") ?

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom