http://qs321.pair.com?node_id=535498


in reply to Search a directory for files

Update: davidrw's response above is much simpler. I was responding to the algorithm as posted, and pointing out that your inner loop needed some work :)

You should probably restructure your inner loop, and pull the GenerateTestFileList() call outside of it.
my $count = 0; foreach (@keywords) { if( ($_ eq "database.txt") || ($_ eq "keywords_database.txt") ) { print "Found $_\n"; $count++; last if($count == 2); } } if($count != 2) { print "At least one database is missing.\n"; GenerateTestFileList(); }
I would also recommend using the string equality operator (eq) instead of regular expressions. You know exactly what the files are named, and you don't want an accidental match. For example, the strings "random_database.txt" and "some_other_database.txt.tar.gz" will match your elsif(@keywords[$kdbase] =~ /database\.txt/) line above.

Replies are listed 'Best First'.
Re^2: Search a directory for files
by gzayzay (Sexton) on Mar 09, 2006 at 20:44 UTC
    Thanks for that observation. I will consider that change.