http://qs321.pair.com?node_id=11134735


in reply to Re^2: Insecure CPAN module in taint mode
in thread Insecure CPAN module in taint mode

sensible way to untaint $ENV{'PATH'} without losing the portability

Just set $ENV{'PATH'} to /bin:/usr/bin. That's what you get by default when nothing else is set (default set in init, libc, and some other places), and that's where all important binaries can be found. If you need "exotic programs" that are not in /bin or /usr/bin, put their path into the configuration file.

my $path = $ENV{'PATH'}; $ENV{'PATH'} = undef; foreach my $p(split /:/, $path) { if ($p =~ m!^(/(usr|bin).*)!) { $ENV{'PATH'} .= ':' if $ENV{'PATH'}; $ENV{'PATH'} .= $1; } }

That looks broken.

You add every element of PATH to the new PATH if it starts with /usr or /bin. Including /usr/u0/evil.me (that's how HOME once looked like, before /home became common), /binary/garbage, /usr.corrupted, /usr/sbin, /usr/svr4/bin, /usr/etc, and so on.

Also, why don't you use join to combine the "cleaned" elements?

Just don't. The predefined PATH is unreliable, that's why perl considers it tainted. Set a sane default, don't try to repair the mess found in PATH. It just makes things worse. /bin:/usr/bin is sane.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

Replies are listed 'Best First'.
Re^4: Insecure CPAN module in taint mode
by Bod (Parson) on Jul 06, 2021 at 22:17 UTC
    Just don't. The predefined PATH is unreliable, that's why perl considers it tainted

    I was thinking that I didn't know what else or why else the other parts of PATH are. But, I suppose it doesn't really matter as long as I don't want to make use of them which I don't!

    I'll set it to /bin:/usr/bin as you suggest - thanks