http://qs321.pair.com?node_id=727279


in reply to RFC: CGI::Uploader V 2.90_01

Ron,

Thanks your interest in this. I'm curious about the decision to move the imaging code into the core. Uploading could be about a lot of other transformations besides image resizing, and the old design of handing image transformations through a helper module seemed like a reasonable interface:

Before:

gen_files => { 'my_thumb' => gen_thumb({ w => 100, h => 100 }), }
After:
transform => { imager => Imager -> new(), options => {xpixels => 400, ypixels => 500}, }
That looks worse to me, and sets a precedent for supporting imagers internally, while before there was example of adding new transformers via plugins.

Replies are listed 'Best First'.
Re^2: RFC: CGI::Uploader V 2.90_01
by ron.savage (Acolyte) on Dec 04, 2008 at 02:46 UTC
    Hi Mark. Actually, I'm very uneasy about embedding such restricted transformation logic in the module. The feedback has confirmed my suspicions that that part needs to be re-implemented. I was a good idea to call this one 2.90_01 and not 3.00 :-). Cheers