in reply to Re: Please evaluate: RegEx for validating e-mail addresses
in thread Please evaluate: RegEx for validating e-mail addresses
Hi, jdalbec. Thanks for replying.
Please use <code> tags around Perl code so it displays correctly.
Actually I used, but since the <code> tags are inside a <ol> tag maybe they aren't displaying correctly...
You may want to use (?: ... ) for grouping so you don't get a bunch of assignments to $1, $2, etc.
True, thanks for pointing this out.
Also {1} is redundant.
Also true. Thanks again, but...
In several cases your comments don't match what the regexp is doing.
Actually I've made a lot of testing and apparently it is... Could you clarify this part a little? I'm curious.
In 2. the (\.)+ allows two or more dots in a row. I think you probably just want to drop the + (and the redundant parentheses).
and
In 3. you have almost the same problem. Try changing * to ? unless you mean to allow multiple dashes/underscores in a row.
Actually I want to allow multiple dots, dashes and underscores since 'er.galvao.abbott@somedomain.com' or 'er_galvao_abbott@somedomain.com' are valid addresses.
In 9. I think you want (?:\.(?:[a-z0-9]){2,})*. I'm leaving the * (even though you said "possibly") since I think you can have any number of domain levels in a FQDN.
Thanks, I'll give this chunk a try and see what happens.
Thanks a lot for your reply,
Please use <code> tags around Perl code so it displays correctly.
Actually I used, but since the <code> tags are inside a <ol> tag maybe they aren't displaying correctly...
You may want to use (?: ... ) for grouping so you don't get a bunch of assignments to $1, $2, etc.
True, thanks for pointing this out.
Also {1} is redundant.
Also true. Thanks again, but...
In several cases your comments don't match what the regexp is doing.
Actually I've made a lot of testing and apparently it is... Could you clarify this part a little? I'm curious.
In 2. the (\.)+ allows two or more dots in a row. I think you probably just want to drop the + (and the redundant parentheses).
and
In 3. you have almost the same problem. Try changing * to ? unless you mean to allow multiple dashes/underscores in a row.
Actually I want to allow multiple dots, dashes and underscores since 'er.galvao.abbott@somedomain.com' or 'er_galvao_abbott@somedomain.com' are valid addresses.
In 9. I think you want (?:\.(?:[a-z0-9]){2,})*. I'm leaving the * (even though you said "possibly") since I think you can have any number of domain levels in a FQDN.
Thanks, I'll give this chunk a try and see what happens.
Thanks a lot for your reply,
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^3: Please evaluate: RegEx for validating e-mail addresses
by jdalbec (Deacon) on Sep 30, 2004 at 01:51 UTC |
In Section
Seekers of Perl Wisdom