http://qs321.pair.com?node_id=32492


in reply to RE: Code Review section, anyone?
in thread Code Review section, anyone?

I think Seekers is quite different from what was proposed for the code review section.

Seekers:
the code doesn't work; the poster is stuck. Post the minimal example and describe errors.
Code Review:
the code works, but the poster wants to know if there's a way to improve a function's efficiency, or if there are some bugs in the module that s/he hasn't seen, or if there's a pitfall in the program s/he didn't notice.

That said, I think Review is more or less like Craft.

See the description of the various sections. I get the impression that snippets and catacombs could easily be used for polished pieces of (snippets and standalone programs respectively) code (polished modules belong at CPAN of course). The code in these sections should be good enough for someone to use. It might actually be nice to have these sections moderated, allowing only code that passed review to be found in these sections.

Craft, on the other hand, is a place to show off code. If something's on display, it's going to get comments and critique...at least that's how I see it.

Update: Merlyn, I agree that it's good to have it clear that people will critique. I just think a new section would be redundant. If Craft is what I think it is (and if not, what is it for?), it would certainly benefit from a clearer description, and possibly even from being renamed to Review.