in reply to Get a hash object from a database with DBI for use with HTML::Template
A couple of comments on your code:
T I M T O W T D I
- You should use placeholders for values where possible for many reasons, including security, problems with quoting etc. That is you should change
intomy $stmt = "SELECT * FROM $table WHERE $key_col = '$key_val'"; my $sth = $dbhandle->prepare( $stmt ); $sth->execute();my $stmt = "SELECT * FROM $table WHERE $key_col = ?"; my $sth = $dbhandle->prepare( $stmt ); $sth->execute($key_val); - You should errorcheck your database stuff. Add a || die $DBI::errstr to all your DBI->connect, $dbh->prepare and $sth->execute.
- You only need two row, so only get those. That is change:
intomy $ref = $sth->fetchall_arrayref(); $sth->finish(); return map { $_->[$name_col] => $_->[$val_col] } @$ref;my $ref = $sth->fetchall_hashref([$name_col,$val_col]); $sth->finish(); return map {@$_} @$ref; - print "Content-Type: text/html\n\n"; is wrong. The HTTP standard says it should be \r\n\r\n. However most browsers dont care ;)
- Dont use a & in a sub call without needing it. It overrides any prototype you may add at a later time to make perl check the number/type of params to get_hash.
- Dont overgeneralize. If you only use get_hash for this specific purpose, then fill in the tablename/colname and select only the two rows you need instead of *.
T I M T O W T D I
|
---|
Replies are listed 'Best First'. | |
---|---|
(jeffa) 2Re: Get a hash object from a database with DBI for use with HTML::Template
by jeffa (Bishop) on Aug 04, 2002 at 17:12 UTC |
In Section
Cool Uses for Perl