Re^2: Limit loop

in reply to Re: Limit loop
in thread Limit loop

foreach ( @favs[ 0 .. 24 ] ) {

Since the original post said only "a few of these favorite fields have more than 25", then most of the time, that will end up with one or more undef iterations on the loop, so then undef would have to be handled specially. Maybe via next unless defined; or similar logic.

Comment on Re^2: Limit loop Select or Download Code

Replies are listed 'Best First'.
Re^3: Limit loop by htmanning (Friar) on Aug 30, 2022 at 21:10 UTC
Thanks but this didn't work. It just throws the same end of script output before header error. And YES, most of them have less than 25 favs but some do have more. Most of the time this is a non issue.	[reply]
Re^4: Limit loop by pryrt (Abbot) on Aug 30, 2022 at 21:44 UTC
Your script not working has nothing to do with whether or not the loop properly exits after a maximum of 25 loops. You need to fix your bugs before declaring that someone's solution for a small question is invalid. Thi spoiler contains an SSCCE that fixes (some) of your mistakes, with comments. But in brief, you didn't use strict and warnings, so you missed some of the problems; you initialized the wrong variable outside of your loop (which would have been caught by strict/warnings); and your vertical bar split had too many vertical bars, so it never split your loop variable into three variables (instead, putting the whole string in the $favtitle and leaving $favlink and $favnum as undef). The code below shows the same loop working for both 5 favorites in the string (showing all) and for 30 favorites in the string (showing 25 of them). <Reveal this spoiler or all in this thread> edit: struck about the vertical bar; the eventual follow-on data shows that there really are 3 bars between fields. Sorry.	[reply] [d/l]
Re^4: Limit loop by jwkrahn (Monsignor) on Aug 30, 2022 at 21:57 UTC
Before the loop remove the excess elements `splice @favs, 25; foreach (@favs){` [download]	[reply] [d/l]
Re^5: Limit loop by AnomalousMonk (Archbishop) on Aug 31, 2022 at 19:18 UTC
`splice @favs, 25;` [download] Note that splice-ing past the end of the array results in a warning in earlier Perl versions: `Win8 Strawberry 5.8.9.5 (32) Wed 08/31/2022 15:05:47 C:\@Work\Perl\monks >perl -wMstrict -MData::Dump=dd -le "my @ra = ('a' .. 'd'); splice @r +a, 10; dd \@ra" splice() offset past end of array at -e line 1. ["a" .. "d"]` [download] (I don't know with what version this warning was suppressed.) Give a man a fish: `<%-{-{-{-<`	[reply] [d/l] [select]

In Section Seekers of Perl Wisdom